Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

micro frontend blog #77

Merged
merged 16 commits into from
Dec 13, 2023
Merged

micro frontend blog #77

merged 16 commits into from
Dec 13, 2023

Conversation

harsh-julka-bb
Copy link
Contributor

@harsh-julka-bb harsh-julka-bb commented Nov 21, 2023 •
edited
Loading

What is this article about?

R: Angular & Micro Frontends

Checklist:

  • I am added to the list of authors correctly.
  • All images used in the post is in the correct folder (assets/images/post/).
  • My article has been reviewed internally before opening this Pull Request.
  • I have not modified someone else's previously published articles.
  • I double checked my changes locally at http://127.0.0.1:4000/ after running bundle install && bundle exec jekyll serve.
  • My changes generate no new errors

robinsonzimmermann
robinsonzimmermann reviewed Nov 22, 2023
View reviewed changes
Copy link
Member

@robinsonzimmermann robinsonzimmermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, but I have a few minor comments. Can you please have a look?

_posts/2023-11-14-setup-microfrontend.md Outdated Show resolved Hide resolved
_posts/2023-11-14-setup-microfrontend.md Outdated Show resolved Hide resolved
_posts/2023-11-14-setup-microfrontend.md Outdated Show resolved Hide resolved
_posts/2023-11-14-setup-microfrontend.md Outdated Show resolved Hide resolved
_posts/2023-11-14-setup-microfrontend.md Outdated Show resolved Hide resolved
_posts/2023-11-14-setup-microfrontend.md Outdated Show resolved Hide resolved
robinsonzimmermann
robinsonzimmermann reviewed Dec 1, 2023
View reviewed changes
_posts/2023-11-14-setup-microfrontend.md Outdated Show resolved Hide resolved
_posts/2023-11-14-setup-microfrontend.md Outdated Show resolved Hide resolved
_posts/2023-11-14-setup-microfrontend.md Outdated Show resolved Hide resolved
_posts/2023-11-14-setup-microfrontend.md Outdated Show resolved Hide resolved
_posts/2023-11-14-setup-microfrontend.md Outdated Show resolved Hide resolved
_posts/2023-11-14-setup-microfrontend.md Outdated Show resolved Hide resolved
_posts/2023-11-14-setup-microfrontend.md Outdated Show resolved Hide resolved
_posts/2023-11-14-setup-microfrontend.md Outdated Show resolved Hide resolved
_posts/2023-11-14-setup-microfrontend.md Outdated Show resolved Hide resolved
_posts/2023-11-14-setup-microfrontend.md Outdated Show resolved Hide resolved
@harsh-julka-bb harsh-julka-bb merged commit 28ef146 into main Dec 13, 2023
2 of 3 checks passed
@harsh-julka-bb harsh-julka-bb deleted the article/micro-frontend branch December 13, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinsonzimmermann robinsonzimmermann robinsonzimmermann approved these changes

@yash-kapila yash-kapila yash-kapila approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harsh-julka-bb @yash-kapila @robinsonzimmermann