refactor: change to use new msu affordability preview system #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darxo
approved these changes
Apr 21, 2024
Instead of comparing preview values. I realized that it is ok to use these functions because they are based on CurrentProperties and we don't mess with that during update functions.
LordMidas
force-pushed
the
refactor-change-to-new-msu-affordability-system
branch
from
30677a7 to
85789ca
Compare
|
I've created an even better affordability system in MSU so the PR has been updated to account for that. Please re-review based on the changes in the latest commit. |
Darxo
requested changes
May 13, 2024
Darxo
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the new affordability system I am implementing in MSU.
EDIT: 2024-05-10
I've created an even better affordability system in MSU so the PR has been updated to account for that.