Adds in an advanced mode to the preferences screen to hide some preferences #12168
Conversation
github-actions
bot
added
the
TGUI-Changes
|
admin brief outfit isnt rendering properly in the window |
|
It's always done that. The text can't wrap because it has no spaces, and the dropdown isn't wide enough to fit it. It doesn't matter and it's not this PR's problem |
| onClick={() => { | ||
| setAdvancedSettings(!advancedSettings); | ||
| }}> | ||
| Show Advanced Settings |
There was a problem hiding this comment.
I'm unhappy with how this looks. The button is pretty large, and it decenters the very intentionally placed searchbar. It might have some place in the titlebar of the window. I think if you reduce the length of the text in here (maybe just use an icon instead?) and add some margins around it, fix the centering of the searchbar.. it should be OK.
There was a problem hiding this comment.
An icon would probably be confusing, I could probably reduce the text but I think this is the most appropriate space for it. It has a fixed width so doesn't cause elements of the UI to jump around and cause confusion and handles scaling nicely.
I can move it, but I think putting it in the titlebar wouldn't be an improvement since it would be away from the rest of the elements that do the same thing and would ruin the quite nice heirarchy that the UI has going on where from top to bottom it gets more refined
- Player vs character prefs
- Settings vs Keybinds
- Filters
- Links
- Actions
There was a problem hiding this comment.
I'll try reducing the length of the text
There was a problem hiding this comment.
To be honest, it doesn't really make much of a difference. The search bar is big enough anyway and I think this is a fine location
|
Preferences are stored in the database regardless of whether or not the user changed them, meaning that I am unable to find the most commonly changed preferences (When getting the data from crossed, it turns out the preferences are in order of when they were added and not in order of change frequency). I have picked appropriate preferences for this PR. |
|
oh I forgot to commit it |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
About The Pull Request
I am waiting to get some data about the most popular changed preferences, to add those to the default view.
Why It's Good For The Game
The preference screen is huge and hard to navigate, most players likely won't know what half the preferences actually do and there are some that they just shouldn't be changing.
By hiding preferences that most people won't want to change, we make it easier for players to change the preferences they actually should be changing.
I have chosen to keep the preferences that:
Most of the preferences that I've hidden are:
Testing Photographs and Procedure
Changelog
🆑
tweak: Altered the game preference menu to hide less important settings and dangerous settings by default.
tweak: Changes ghost ears, ghost whispers and ghost emotes to be false by default to prevent players being spammed in the chat by default.
/:cl: