-
-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Juicing (rkz edition) #12170
Fixes Juicing (rkz edition) #12170
Conversation
I swear this is like the third fix for juicing |
And that brings us to now. Where the procs are now changed to exactly what they should be, all of the holder procs now only accept typepaths, and the issue is finally resolved. |
Will test when this is merged. (Thank you for doing this) |
Does the unit test for reagent grinders actually function now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adds various juice types as juice_item results of juice_typepath. Maintains brains not being blendable, sets watermelon and watermelon slices to create watermelon juice. nymphs create chlorophyll. swaps out some juice_results to Juice_typepath for coherence.
Was testmerged with no complaints.
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
About The Pull Request
Some serious shit was missed in the foodening pr, which broke juicing.
Pro-tip? If you are porting something always check the description of the pr for fixes. (also don't merge features before fixes)
Lets just fix it yea?
Ports:
Why It's Good For The Game
You can juice stuff again
Testing Photographs and Procedure
Screenshots&Videos
dreamseeker_3pGehqxOgi.mp4
Changelog
🆑 rkz, lizardqueenlexi, SyncIt21
fix: fixes juicing not giving juice (I promise <3)
fix: fixes food trash not appearing
fix: grinding stacks now grinds as many pieces/sheets from the stack as possible that can fit in a beaker/container without wasting the whole stack
fix: All in 1 grinder now mixes faster with upgraded parts
code: reagent holder code will no longer accept non-typepaths in procs (it expects reagent typepaths)
/:cl: