Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two more ghost scanners, refactors and improves the handheld genetics scanner #12187

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

SunShine214
Copy link
Contributor

@SunShine214 SunShine214 commented Jan 22, 2025

About The Pull Request

Adds a virus and genetics ghost scanner, as well as refactoring both the virus scan and genetics scan procs to be able to be used without an item attached to them.

Why It's Good For The Game

Being able to scan things as a ghost is fun, and makes observing more enjoyable. Additionally, the genetics sequencer was not very great, so its been improved to be more similar to other scanners.

Testing Photographs and Procedure

Screenshot 2025-01-22 154327

Screenshot 2025-01-22 154117

Screenshot 2025-01-22 154102

Screenshots&Videos

Changelog

🆑
add: Added virology and genetics scanners as new ghost scanners.
tweak: Improved the genetics sequencer to be more visually pleasing as well as more in-line with other scanner outputs.
refactor: Refactored related scan procs to no longer require the items related to them
/:cl:

@SunShine214 SunShine214 changed the title Add two more ghost scanners, refactor and improve the handheld genetics scanner Add two more ghost scanners, refactors and improves the handheld genetics scanner Jan 22, 2025
@Therealdoooc213
Copy link
Contributor

Your testing evidence isn't loading
image

@SunShine214
Copy link
Contributor Author

Your testing evidence isn't loading image

I have literally no idea how to fix it, the links work fine by themselves.... I just used the "attach file" button.

@mrmanlikesbt
Copy link
Contributor

mrmanlikesbt commented Jan 23, 2025

video/image embeds need to have an empty line under them

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added Administration TGUI-Changes Contains changes to TGUI. Make sure its up to date with TGUI 4.0 and removed Merge Conflict labels Jan 23, 2025
@SunShine214
Copy link
Contributor Author

oops messed up merge conflict raaaaaa

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed Administration TGUI-Changes Contains changes to TGUI. Make sure its up to date with TGUI 4.0 labels Jan 23, 2025
@SunShine214
Copy link
Contributor Author

....after merging and fixing pull conflicts the chat box is now permanently empty in local, I have no idea what the issue is.

@SunShine214
Copy link
Contributor Author

converting this to draft until I figure out the chat issue, though I dont think its caused by me.

@SunShine214 SunShine214 marked this pull request as draft January 24, 2025 00:09
@SunShine214
Copy link
Contributor Author

chat issue was in fact not me, and from the remove context pr

@SunShine214 SunShine214 marked this pull request as ready for review January 24, 2025 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants