Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load rules_android and providers #58

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kateliu20
Copy link

Running bazel build :lint with bazel version 8 and was able to run successfully after adding rules_android bazel dep.

MODULE.bazel Outdated
@@ -4,6 +4,7 @@ module(
compatibility_level = 1,
)

bazel_dep(name = "rules_android", version = "0.5.0")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a newer version out already, might be worth while just using that directly. 6.0.0 should also decouple us from needing the .bazelrc flags for enabling access to the native providers.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, I upgraded here: d23ab76

"@rules_android//providers:providers.bzl",
"AndroidLibraryResourceClassJarProvider",
"AndroidLibraryAarInfo"
)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add JavaInfo loads as well? They can be loaded from rules_java now.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is like this okay? e75150a

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks correct!

@Bencodes
Copy link
Owner

@kateliu20 can you take a look at the failing CI checks?

@kateliu20
Copy link
Author

kateliu20 commented Dec 18, 2024

It seems like the CI checks are all failing because it cannot find rules_android version 6.0.0:
module not found in registries: [email protected] @Bencodes do you have suggestions of what other versions I could use or if I need to upgrade to bazel 8?

edit: I will upgrade to bazel 8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants