-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load rules_android and providers #58
base: main
Are you sure you want to change the base?
Conversation
MODULE.bazel
Outdated
@@ -4,6 +4,7 @@ module( | |||
compatibility_level = 1, | |||
) | |||
|
|||
bazel_dep(name = "rules_android", version = "0.5.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a newer version out already, might be worth while just using that directly. 6.0.0 should also decouple us from needing the .bazelrc flags for enabling access to the native providers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, I upgraded here: d23ab76
"@rules_android//providers:providers.bzl", | ||
"AndroidLibraryResourceClassJarProvider", | ||
"AndroidLibraryAarInfo" | ||
) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add JavaInfo
loads as well? They can be loaded from rules_java
now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is like this okay? e75150a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks correct!
@kateliu20 can you take a look at the failing CI checks? |
It seems like the CI checks are all failing because it cannot find rules_android version 6.0.0: edit: I will upgrade to bazel 8 |
Running
bazel build :lint
with bazel version 8 and was able to run successfully after addingrules_android
bazel dep.