Move over to the official bazel_worker implementation #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bencodes
force-pushed
the
move-over-to-the-official-bazel_worker-implementation
branch
from
84426cc to
a2d58bf
Compare
Bencodes
force-pushed
the
move-over-to-the-official-bazel_worker-implementation
branch
from
a2d58bf to
49fd781
Compare
kateliu20
reviewed
Jan 19, 2025
| }, | ||
| realStdErr, | ||
| ProtoWorkerMessageProcessor(System.`in`, System.out), | ||
| ).setCpuUsageBeforeGc(Duration.ofSeconds(10)) |
There was a problem hiding this comment.
Can I ask what the purpose of setting this is and why you chose 10 seconds specifically?
There was a problem hiding this comment.
Copied this from the usages within Bazel core and their examples.
There was a problem hiding this comment.
Sounds good, the PR looks good to me from my perspective.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating over to the official Bazel worker implementation so that these rules don't have to maintain their own internal implementation.
This PR also moves the underlying worker communication from json over to proto.