Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace c_intmax_t with c_int64_t #149

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Replace c_intmax_t with c_int64_t #149

merged 4 commits into from
Dec 18, 2024

Conversation

ktras
Copy link
Collaborator

@ktras ktras commented Dec 17, 2024 •
edited
Loading

Closes #150.

ktras added 3 commits December 17, 2024 10:32
@ktras
fix: Change c_intmax_t to c_int64_t in procedure interfaces
f9c8e79 
To match PRIF v0.5, update the kind of some integer arguments from
`c_intmax_t` to `c_int64_t` and update the `caf_image_index` test
accordingly.
@ktras
fix: Change more c_intmax_t to c_int64_t in interfaces
5bbe1df 
To match PRIF v0.5, update the kind of more integer arguments from
`c_intmax_t` to `c_int64_t` and update the `caf_teams` test
accordingly.
@ktras
fix: Replace all remaining c_intmax_t references to c_int64_t
f8e6dd4 
Also replace `intmax_t` to `int64_t` in the C code
bonachea
bonachea requested changes Dec 17, 2024
View reviewed changes
Copy link
Member

@bonachea bonachea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made one minor tangential request, otherwise LGTM

src/caffeine/caffeine.c Show resolved Hide resolved
@ktras ktras requested a review from bonachea December 17, 2024 21:58
@ktras ktras merged commit 292d69e into main Dec 18, 2024
6 checks passed
@bonachea bonachea deleted the replace-c_intmax_t-with-c_int64_t branch December 23, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonachea bonachea bonachea approved these changes

@everythingfunctional everythingfunctional everythingfunctional approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace c_intmax_t with c_int64_t
3 participants
@ktras @everythingfunctional @bonachea