Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable tests that are known to be broken with flang-new #175

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

bonachea
Copy link
Member

With this change run-fpm.sh test now passes "out of the box" on a recent snapshot of flang-new, and prints a warning about skipping tests for features that are known to remain broken.

Support for flang-new remains in an experimental state, but this should help us avoid regressions on working functionality.

Example:

perlmutter$ flang-new --version
flang-new version 20.0.0git ([email protected]:llvm/llvm-project.git a4fdabeea997203edfe777c62c290c809217d0ac)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: [redacted]
Build config: +assertions

perlmutter$ env GASNET_PSHM_NODES=4 CC=clang CXX=clang++ FC=flang-new ./build/run-fpm.sh test 
Project is up to date
 -----------------------------------------------------------------
 WARNING: flang-new compiler detected.
 WARNING: Skipping tests that are known to fail with this compiler
 -----------------------------------------------------------------
Running Tests

Test that
    A caffeinated beverage
        is served: the prif_init() function completes successfully.
        a subsequent prif_init call returns PRIF_STAT_ALREADY_INIT
    PRIF allocation can
        allocate, use and deallocate an integer scalar coarray with a corank of 1
        allocate, use and deallocate memory non-symmetrically
    PRIF coarray inquiry functions
        prif_local_data_pointer
            returns the same pointer as when the coarray was allocated
    The prif_co_broadcast subroutine
        broadcasts a default integer scalar with no optional arguments present
        broadcasts a derived type scalar with no allocatable components
    prif_image_index
        returns 1 for the simplest case
        returns 1 when given the lower bounds
        returns 0 with invalid subscripts
        returns the expected answer for a more complicated case
    The prif_num_images function result
        is a valid number of images when invoked with no arguments
    PRIF RMA
        can send a value to another image
        can send a value with indirect interface
        can get a value from another image
        can get a value with indirect interface
    Teams
        can be created, changed to, and allocate coarrays
    The prif_this_image_no_coarray function result
        is the proper member of the set {1,2,...,num_images()} when invoked as this_image()

A total of 18 test cases

All Passed
All Passed
All Passed
All Passed
Took 0.115456 seconds
Took 0.115445 seconds
Took 0.115429 seconds
Took 0.115437 seconds




A total of 18 test cases containing a total of 43 assertions
A total of 18 test cases containing a total of 43 assertions
A total of 18 test cases containing a total of 43 assertions
A total of 18 test cases containing a total of 43 assertions




 STOP
 STOP
 STOP
 STOP

With this change ./build/run-fpm.sh test now passes on flang-new,
and prints a warning about skipping tests for features that are
known to remain broken.
@bonachea bonachea marked this pull request as ready for review January 16, 2025 23:25
@bonachea bonachea requested a review from ktras January 16, 2025 23:25
Copy link
Collaborator

@ktras ktras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bonachea bonachea merged commit 98baa51 into BerkeleyLab:main Jan 16, 2025
3 checks passed
@bonachea bonachea mentioned this pull request Jan 16, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants