-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README-id.md #9
base: master
Are you sure you want to change the base?
Conversation
README-id.md
Outdated
@@ -49,6 +49,9 @@ Anda dapat melihat peta yang telah dirender dari pencarian tersebut dalam berkas | |||
`wikimedia_connected_island_relation.png` pada repo `uni-task-2`, | |||
yang akan memperlihatkan pada Anda bahwa banyak sekali pulau-pulau di Indonesia yang tidak terdapat disana yang bisa disambungkan ke proyek-proyek Wikimedia. | |||
|
|||
Queri di atas hanya menghasilkan data dari objek terluar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sepertinya lebih baik tetap ditulis query
dan dicetak miring. Kata objek
tidak konsisten dengan tulisan sebelumnya yaitu obyek
.
Continued in #10 . Reason: was using default github editing feature. |
That is not a reason to abandon a PR. |
@jayvdb The email address used in the pr is not mine. It was github emails. I though by fetching and ammending the changes in new branch, i will be able to retain my email address, but it wasn't. On #10, apparently, it is still using [email protected]. Which is far from what i intended. I should have created a better comments 😄 |
That is because you dont have a public email address in your GitHub profile. But it isnt necessary. You can use |
It will fix https://tree.taiga.io/project/jayvdb-wikimedia-idanak-pulau/task/18 when merged |
Update readme translation to reflect fb99efb