Better French book abbreviation handling #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fter book abbreviation, and enforce always putting a space between abbreviation and number (rather than sometimes a nnbsp).
NateMerritt
reviewed
Dec 16, 2024
| "jud" or "ju" => "Jd", | ||
| "re" or "rév" or "rev" => "Ap", | ||
| _ => m.Value | ||
| var correctedValue = m.Value.Trim().Replace(".", ""); |
There was a problem hiding this comment.
Does French not use periods for abbreviations?
There was a problem hiding this comment.
Don't want any periods after the abbreviation, just a space. Sometimes the AI would put one and then my replacement logic wouldn't pick it up. So now the regex will pick up a period that's directly after the book name as well (e.g. "Ex. 32.17–18" would match "Ex. " whereas before it wouldn't have matched).
NateMerritt
reviewed
Dec 16, 2024
| }); | ||
|
|
||
| return Task.FromResult(text); | ||
| } | ||
|
|
||
| [GeneratedRegex(@"(?:\d+[^\S\r\n])?([a-zA-Zà-üÀ-Ü]+)(?=[^\S\r\n|\.]\d+)")] | ||
| [GeneratedRegex(@"(?:\d+[^\S\r\n])?([a-zA-Zà-üÀ-Ü]+\.?[^\S\r\n]?)(?=[^\S\r\n]?\d+)")] |
There was a problem hiding this comment.
The main difference here is that this now captures the period if present?
There was a problem hiding this comment.
It matches a period as well as any whitespace. So if it separates the book and verse by a non breaking space I can replace it with a regular space.
NateMerritt
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.