Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brush arguments - replaces 32 and 42 #44

Merged

Conversation

timelyportfolio
Copy link
Contributor

replaces #32 without build files. All discussion is on that pull request and #31.

@BigFatDog BigFatDog merged commit 4d3e2ea into BigFatDog:master Aug 13, 2018
@BigFatDog
Copy link
Owner

Many thanks to your time. v2.1.8 has been released with this feature.
Readme has been revised to introduce this new api.

🍺 Have a good night.

@timelyportfolio
Copy link
Contributor Author

Thanks @gordonwoodhull, I think || [] would be a good fix and will test.

@gordonwoodhull
Copy link

Thanks @timelyportfolio, it's working for me. I'll contribute back once I get my thing working!

timelyportfolio added a commit to timelyportfolio/parcoords-es that referenced this pull request Sep 22, 2018
@timelyportfolio timelyportfolio deleted the feature/brush-arguments2 branch September 22, 2018 13:03
@BigFatDog
Copy link
Owner

Thanks @timelyportfolio for the bug-fix.
v2.1.9 has been released with this bug-fix.

@timelyportfolio
Copy link
Contributor Author

@gordonwoodhull wanted to make sure you saw #47. Thanks again for the notice.

@gordonwoodhull
Copy link

Yes, I saw that, thanks @timelyportfolio!

I still need something like #45 to better deal with external selections/filtering - I gave it a quick look on Friday but haven't had time to dig into porting your changes from the original parcoords.

I'm pursuing this entirely out of intellectual interest, so it keeps getting preempted.

@timelyportfolio
Copy link
Contributor Author

I expect to submit a pull in next couple of days. I have code as proof of concept ready but working up some discussion and demos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants