Add support for seurat hdf5 format. #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for h5seurat format to TENxMatrix object. In this version, only functions in TENxMatrix-class and TENxMatrixSeed-class has been changed. At the same time, I have added a toy data and written some example codes in the help document.
As a concern, the change in .find_rownames_dataset of TENxMatrixSeed-class is a little dangerous. I'm afraid that the 'features' prior than 'features/id' will cause a bug. However, if set 'feature/id' prior, it will cause an error: "Error in H5Lexists(fid, name) : HDF5. Links. Can't get value".
If the bug actually exist, it's maybe a solution to write a new function .read_h5seurat_component to read h5seurat data separately as in my last pull request.