Active ranking #394
Open
Active ranking #394
+313
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+1
to
+4
| import numpy as np | ||
| from typing import Callable, List, Any | ||
| from dataclasses import dataclass | ||
| from collections import defaultdict |
There was a problem hiding this comment.
Note the isort error.
Maybe you need to reinstall the pre-commit hooks? Something like pre-commit install when the repo is the current directory. If I right, you'll need to re-run the pre-commits afterwards to make sure it applies the changes :)
There was a problem hiding this comment.
Besides that the Jenkins seems to pass (after a rebuilt)
mosheraboh
reviewed
Jan 26, 2025
| raise ValueError(f"Unknown method: {method}") | ||
|
|
||
|
|
||
| if __name__ == "__main__": |
There was a problem hiding this comment.
Consider converting it to unittest.
| return global_ranking | ||
|
|
||
|
|
||
| if __name__ == "__main__": |
There was a problem hiding this comment.
consider converting it to unittest
| def __init__( | ||
| self, | ||
| items: List[Any], | ||
| compare_pairwise_fn: Callable[[Any, Any], bool], |
There was a problem hiding this comment.
Can you share some details about the expected arguments of this function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
helper utilities to rank items based on either:
The user is expected to supply such callable, and the helper functions added in this PR will call it iteratively to predict the overall ranking of the entire provided set.