Text and Keyword aggregation integration tests #176
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| /* | ||
| * Copyright OpenSearch Contributors | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| package org.opensearch.sql.sql; | ||
|
|
||
| import org.junit.Test; | ||
| import org.opensearch.sql.legacy.SQLIntegTestCase; | ||
| import java.io.IOException; | ||
|
|
||
|
|
||
| import static org.opensearch.sql.legacy.TestsConstants.TEST_INDEX_TEXTKEYWORD; | ||
| import static org.opensearch.sql.util.MatcherUtils.schema; | ||
| import static org.opensearch.sql.util.MatcherUtils.verifySchema; | ||
|
|
||
| public class TextTypeIT extends SQLIntegTestCase { | ||
|
|
||
|
|
||
| @Override | ||
| public void init() throws Exception { | ||
| super.init(); | ||
| loadIndex(Index.TEXTKEYWORD); | ||
| } | ||
|
|
||
| @Test | ||
| public void textKeywordTest() throws IOException { | ||
| var result = executeJdbcRequest(String.format("select typeText from %s", TEST_INDEX_TEXTKEYWORD)); | ||
| verifySchema(result, | ||
| schema("typeText", null, "text")); | ||
| } | ||
|
|
||
| @Test | ||
| public void aggregateOnText() throws IOException { | ||
| var result = executeJdbcRequest(String.format("select sum(int0) from %s GROUP BY typeText", TEST_INDEX_TEXTKEYWORD)); | ||
| verifySchema(result, | ||
| schema("sum(int0)", null, "integer")); | ||
| } | ||
|
|
||
| @Test | ||
| public void aggregateOnKeyword() throws IOException { | ||
| var result = executeJdbcRequest(String.format("select sum(int0) from %s GROUP BY typeKeyword", TEST_INDEX_TEXTKEYWORD)); | ||
| verifySchema(result, | ||
| schema("sum(int0)", null, "integer")); | ||
| } | ||
|
|
||
| @Test | ||
| public void aggregateOnTextFieldData() throws IOException { | ||
| var result = executeJdbcRequest(String.format("select sum(int0) from %s GROUP BY typeTextFieldData", TEST_INDEX_TEXTKEYWORD)); | ||
| verifySchema(result, | ||
| schema("sum(int0)", null, "integer")); | ||
| } | ||
|
|
||
| @Test | ||
| public void aggregateOnKeywordFieldData() throws IOException { | ||
| var result = executeJdbcRequest(String.format("select sum(int0) from %s GROUP BY typeKeywordFieldNoFieldData", TEST_INDEX_TEXTKEYWORD)); | ||
| verifySchema(result, | ||
| schema("sum(int0)", null, "integer")); | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| { | ||
| "mappings" : { | ||
| "properties" : { | ||
| "typeKeyword" : { | ||
| "type" : "keyword" | ||
| }, | ||
| "typeText" : { | ||
| "type" : "text" | ||
| }, | ||
| "typeKeywordFieldNoFieldData" : { | ||
| "type": "text", | ||
| "fields": { | ||
| "keyword": { | ||
| "type": "keyword", | ||
| "ignore_above": 256 | ||
| } | ||
| } }, | ||
| "typeTextFieldData" : { | ||
| "type": "text", | ||
| "fielddata": true, | ||
|
There was a problem hiding this comment. it would be interesting to know how it works if we have a There was a problem hiding this comment. Added in 2a8fbac. It passes. |
||
| "fields": { | ||
| "keyword": { | ||
| "type": "keyword", | ||
| "ignore_above": 256 | ||
| } | ||
| } | ||
| }, | ||
| "int0" : { | ||
| "type": "integer" | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| {"index": {}} | ||
| {"typeKeyword": "key00", "typeText": "text00", "typeKeywordFieldData": "keyFD00", "typeTextFieldData": "textFD00", "int0": 0} | ||
|
There was a problem hiding this comment. none of these documents have text fields larger than 256, so we aren't testing the ignore_above sub-field. Can we do that? Can we create a field with ignore_above of around 10, and add data (with spaces) larger than 10 characters? There was a problem hiding this comment. 2a8fbac Added and it passes. |
||
| {"index": {}} | ||
| {"typeKeyword": "key01", "typeText": "text01", "typeKeywordFieldData": "keyFD01", "typeTextFieldData": "textFD01", "int0": 1} | ||
| {"index": {}} | ||
| {"typeKeyword": "key02", "typeText": "text02", "typeKeywordFieldData": "keyFD02", "typeTextFieldData": "textFD02", "int0": 2} | ||
| {"index": {}} | ||
| {"typeKeyword": "key03", "typeText": "text03", "typeKeywordFieldData": "keyFD03", "typeTextFieldData": "textFD03", "int0": 3} | ||
| {"index": {}} | ||
| {"typeKeyword": "key04", "typeText": "text04", "typeKeywordFieldData": "keyFD04", "typeTextFieldData": "textFD04", "int0": 4} | ||
| {"index": {}} | ||
| {"typeKeyword": "key05", "typeText": "text05", "typeKeywordFieldData": "keyFD05", "typeTextFieldData": "textFD05", "int0": 5} | ||
| {"index": {}} | ||
| {"typeKeyword": "key06", "typeText": "text06", "typeKeywordFieldData": "keyFD06", "typeTextFieldData": "textFD06", "int0": 6} | ||
| {"index": {}} | ||
| {"typeKeyword": "key07", "typeText": "text07", "typeKeywordFieldData": "keyFD07", "typeTextFieldData": "textFD07", "int0": 7} | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any other tests that you tried? These only look like aggregation tests, but it would be good to know if some of the following would also work:
WHERE field LIKE "keyFD??"WHERE wildcard("field", "keyFD??")SELECT field LIKE "keyFD??"and maybe a couple of string-like functions:
SELECT LOCATE("FD", field)SELECT SUBSTRING(field, 3, 2)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also try
SELECT POSITION(substring IN field)since it seems to fail for text fields (as Margarit demonstrated)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SELECT POSITION(substring IN field)
Passed:
Failed:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check selectPositionTextDataFieldNoFields - its giving you a parser error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, this looks exclusively like an issue with aggregation on text fields.
Strangely, I thought POSITION was going to fail on text fields, since it was failing for Margarit earlier.