Node: add XLEN command #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yury-Fridlyand
approved these changes
Jun 11, 2024
node/src/BaseClient.ts
Outdated
| */ | ||
| public xlen( | ||
| key: string, | ||
| ): Promise<Record<string, Record<string, string[][]>>> { |
There was a problem hiding this comment.
Suggested change
| ): Promise<Record<string, Record<string, string[][]>>> { | |
| ): Promise<number> { |
There was a problem hiding this comment.
good catch, that was a copy-paste error. Good question! I'm not sure... I think we ran into a similar situation with Python at some point where the inner type was incorrect but the tests still pass. I think javascript and python had typing added after the language was initially created so it works a bit differently than Java, maybe the static analysis can't detect that the inner return value is the wrong type and the typing isn't checked during execution? Just a guess, idk
Yury-Fridlyand
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.