frontend: show estimate symbol for pending alt coin transactions #3128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The app should show an estimate symbol for unconfirmed transactions unless the conversion unit and coin unit are both BTC based. With last commit the logic only checked for conversion unit but ignored the actual coin unit, so alt coins didn't have an estimate symbol even though their BTC/sat amount was not final or still and estimate. Regression introduced in 090038f
thisconnect
force-pushed
the
frontend-show-estimate-for-alts
branch
from
de9c193 to
1b8ddca
Compare
With that the ConversionAmount can be used in other places, for instance in send success.
thisconnect
force-pushed
the
frontend-show-estimate-for-alts
branch
from
1b8ddca to
537e4b4
Compare
Moving to components so that ConversionAmount can be re-used in other components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The app should show an estimate symbol for unconfirmed transactions unless the conversion unit and coin unit are both BTC based.
With last commit the logic only checked for conversion unit but ignored the actual coin unit, so alt coins didn't have an estimate symbol even though their BTC/sat amount was not final or still and estimate.
Regression introduced in 090038f