Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1928] Add parameter support for JSON_GET #1929

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

Mobe91
Copy link
Contributor

@Mobe91 Mobe91 commented Aug 14, 2024

Description

Related Issue

Motivation and Context

@Mobe91 Mobe91 requested a review from beikov August 14, 2024 11:23
Copy link
Member

@beikov beikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than what I commented, this looks good.

@Mobe91 Mobe91 force-pushed the 1928-parameter-support-for-json-get branch 3 times, most recently from deb3957 to c55d763 Compare August 19, 2024 12:25
@Mobe91 Mobe91 force-pushed the 1928-parameter-support-for-json-get branch from c55d763 to d862697 Compare August 19, 2024 14:02
@Mobe91 Mobe91 force-pushed the 1928-parameter-support-for-json-get branch from d862697 to c035738 Compare August 19, 2024 16:12
@jwgmeligmeyling
Copy link
Collaborator

We just ran into this issue too 🤣 Took a while to figure out what was happening.

@beikov beikov merged commit 634799c into Blazebit:main Sep 9, 2024
44 checks passed
@Mobe91
Copy link
Contributor Author

Mobe91 commented Sep 9, 2024

@jwgmeligmeyling Must have been a nice surprise to see that the solution has been waiting in this PR already 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants