Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace deprecated efel usages #124

Merged
merged 3 commits into from
Apr 5, 2024
Merged

replace deprecated efel usages #124

merged 3 commits into from
Apr 5, 2024

Conversation

anilbey
Copy link
Contributor

@anilbey anilbey commented Apr 5, 2024

Updates the efel API usage, removes deprecations.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 53.33333% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 59.33%. Comparing base (bf6294d) to head (e72f7b7).

❗ Current head e72f7b7 differs from pull request most recent head b74aa04. Consider uploading reports for the commit b74aa04 to get more accurate results

Files Patch % Lines
bluepyemodel/emodel_pipeline/plotting.py 0.00% 4 Missing ⚠️
bluepyemodel/evaluation/efel_feature_bpem.py 77.77% 2 Missing ⚠️
bluepyemodel/access_point/access_point.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #124   +/-   ##
=======================================
  Coverage   59.33%   59.33%           
=======================================
  Files         106      106           
  Lines        7738     7738           
=======================================
  Hits         4591     4591           
  Misses       3147     3147           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anilbey anilbey marked this pull request as ready for review April 5, 2024 13:21
Copy link
Collaborator

@ilkilic ilkilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you!

Copy link
Collaborator

@AurelienJaquier AurelienJaquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@anilbey anilbey merged commit a099656 into main Apr 5, 2024
7 checks passed
@darshanmandge darshanmandge deleted the efel branch June 19, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants