Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix in replace_axon_legacy #130

Merged
merged 9 commits into from
Apr 22, 2024
Merged

Small fix in replace_axon_legacy #130

merged 9 commits into from
Apr 22, 2024

Conversation

ilkilic
Copy link
Collaborator

@ilkilic ilkilic commented Apr 22, 2024

  • fix the axon check in replace_axon_legacy
  • add ipyparallel troubleshooting to README

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.16%. Comparing base (a099656) to head (9d52447).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
- Coverage   59.33%   59.16%   -0.17%     
==========================================
  Files         106      107       +1     
  Lines        7738     7795      +57     
==========================================
+ Hits         4591     4612      +21     
- Misses       3147     3183      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ilkilic ilkilic self-assigned this Apr 22, 2024
Copy link
Collaborator

@AurelienJaquier AurelienJaquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

Copy link
Collaborator

@darshanmandge darshanmandge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ilkilic ilkilic merged commit 89354c9 into main Apr 22, 2024
7 checks passed
@ilkilic ilkilic deleted the fix-replace-axon-legacy branch June 19, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants