Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write prebuffered data #18

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Write prebuffered data #18

wants to merge 4 commits into from

Conversation

jorblancoa
Copy link
Collaborator

Create a new API call to provide a writting mechanism given a prebuffered data and the number of steps in the buffer.

CMakeLists.txt Outdated Show resolved Hide resolved
size_t buffered_data_size,
uint32_t steps_to_write) {
if (sonata_report.is_empty()) {
return -3;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Minor] You could also use standard errno values:
https://man7.org/linux/man-pages/man3/errno.3.html

Copy link
Collaborator

@sergiorg-hpc sergiorg-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just minor comments here and there, mostly out of curiosity.

@pramodk
Copy link
Contributor

pramodk commented Oct 12, 2021

As this is draft and needs to be discussed in the context of coreneuron + gpu integration aspects, I will review this after coreneuron discussion.
@jorblancoa : I think it will be helpful to have a brief discussion / provide summary of how existing reporting works (implementation aspects) in coreneuron+libsonatareport execution. This will give a better clarity to @olupton @iomaganaris @sergiorg-hpc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants