Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements #86

Merged
merged 31 commits into from
Mar 31, 2023
Merged

Improvements #86

merged 31 commits into from
Mar 31, 2023

Conversation

Sujay-Shankar
Copy link
Collaborator

No description provided.

The line below will throw a TypeError anyway
We're just scaling the spectrum, short words better
This reverts commit ccfacf8.
WARNING! continuum, rv, smoothing, scale, and spot_temp are optimized and are using a different system than update_native. Do not use this commit and mix and match those sliders.
It even handles the edges!
And oh does it look good
@Sujay-Shankar Sujay-Shankar requested a review from gully March 4, 2023 00:53
@Sujay-Shankar
Copy link
Collaborator Author

Closes #85

Punishes the user ten times less for dragging the slider
Copy link
Member

@gully gully left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had a great in person review with @SujayShankarUT I'm gonna go ahead and merge this and we can beta test it on main 👏

@gully gully merged commit 02df5b8 into main Mar 31, 2023
@gully gully deleted the improvements branch April 7, 2023 16:54
@gully gully mentioned this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants