Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV-9278] US maps with states, state text labels missing #1837

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

khartco
Copy link
Collaborator

@khartco khartco commented Jan 14, 2025

[DEV-9278]

State labels enabled by default, add stroke color around state labels for increased contrast. Tooltips to recommend state labels be enabled.

Testing Steps

  • Create a new US map, or use a config without the displayStateLabels specifed.
    • State labels should be enabled by default
  • Use a US map config with colored state background colors
    • On light colored states: State labels should appear dark gray with a white stroke
    • On dark colored states: State labels should appear white with a gray stroke
  • In the editor, the toggle for state labels should have a new tooltip recommending to leave enabled.

Self Review

  • I have added testing steps for reviewers
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests are passing

Screenshots (if applicable)

n/a

Additional Notes

n/a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant