Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV-9281] Bar charts with no labels or borders fail non-text contrast #1838

Merged
merged 1 commit into from
Jan 15, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -209,6 +209,10 @@ const PanelGeneral: FC<PanelProps> = props => {
<Icon display='question' style={{ marginLeft: '0.5rem' }} />
</Tooltip.Target>
<Tooltip.Content>
<p>
Recommended set to display for Section 508 compliance.
</p>
<hr/>
<p>
Selecting this option will <i> not </i> hide the display of "zero value", "suppressed data", or
"missing data" indicators on the chart (if applicable).
Original file line number Diff line number Diff line change
@@ -138,6 +138,21 @@ const PanelVisual: FC<PanelProps> = props => {
)}
{visHasBarBorders() && (
<Select
tooltip={
<Tooltip style={{ textTransform: 'none' }}>
<Tooltip.Target>
<Icon
display='question'
style={{ marginLeft: '0.5rem', display: 'inline-block', whiteSpace: 'nowrap' }}
/>
</Tooltip.Target>
<Tooltip.Content>
<p>
Recommended set to display for Section 508 compliance.
</p>
</Tooltip.Content>
</Tooltip>
}
value={config.barHasBorder}
fieldName='barHasBorder'
label='Bar Borders'
4 changes: 2 additions & 2 deletions packages/chart/src/data/initial-state.js
Original file line number Diff line number Diff line change
@@ -13,7 +13,7 @@ export default {
animate: false,
lineDatapointStyle: 'hover',
lineDatapointColor: 'Same as Line',
barHasBorder: 'false',
barHasBorder: 'true',
isLollipopChart: false,
lollipopShape: 'circle',
lollipopColorStyle: 'two-tone',
@@ -188,7 +188,7 @@ export default {
palette: 'monochrome-1',
isPaletteReversed: false
},
labels: false,
labels: true,
dataFormat: {
commas: false,
prefix: '',