Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add immunizations to condition summary section #3086

Merged
merged 10 commits into from
Jan 6, 2025

Conversation

BobanL
Copy link
Collaborator

@BobanL BobanL commented Dec 26, 2024

PULL REQUEST

Summary

What changes are being proposed?

Related Issue

Fixes #2597

Acceptance Criteria

  • Check why the TCR service doesn't accept the anthrax vaccine codes in the examples above, and fix if possible (or make into separate ticket if it's a significant amount of work)
  • Modify the eCR Summary so that if immunizations are stamped by the TCR service, they are displayed in the eCR Summary under "Clinical Sections Relevant to Reportable Condition"
  • Add unit and snapshot tests

Additional Information

image

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.40%. Comparing base (ea9e9f2) to head (6a5b029).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3086      +/-   ##
==========================================
+ Coverage   86.82%   88.40%   +1.58%     
==========================================
  Files         219       90     -129     
  Lines       13612     4616    -8996     
  Branches      705      699       -6     
==========================================
- Hits        11818     4081    -7737     
+ Misses       1785      526    -1259     
  Partials        9        9              
Flag Coverage Δ
ecr-viewer 90.05% <100.00%> (+0.03%) ⬆️
fhir-converter ?
ingestion ?
message-parser ?
message-refiner ?
orchestration 85.67% <ø> (ø)
record-linkage ?
trigger-code-reference 86.85% <ø> (ø)
validation ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../ecr-viewer/src/app/services/ecrSummaryService.tsx 94.82% <100.00%> (+0.33%) ⬆️
...viewer/src/app/view-data/components/EcrSummary.tsx 100.00% <100.00%> (ø)
...ecr-viewer/src/app/view-data/components/common.tsx 99.38% <100.00%> (ø)
containers/trigger-code-reference/app/main.py 90.41% <ø> (ø)

... and 129 files with indirect coverage changes

@BobanL
Copy link
Collaborator Author

BobanL commented Dec 26, 2024

@ashton-skylight - ready for design review!
image

@ashton-skylight
Copy link
Collaborator

@BobanL reviewed! thank you so much

@BobanL BobanL requested a review from mcmcgrath13 January 3, 2025 14:18
Copy link
Collaborator

@mcmcgrath13 mcmcgrath13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💉

@BobanL BobanL enabled auto-merge January 6, 2025 16:13
@BobanL BobanL added this pull request to the merge queue Jan 6, 2025
Merged via the queue into main with commit b02e070 Jan 6, 2025
20 checks passed
@BobanL BobanL deleted the boban/2597-relevant-immunization branch January 6, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add relevant immunizations to reportable conditions summary
3 participants