Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify button font weight when filters are applied/not applied #3129

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

angelathe
Copy link
Collaborator

PULL REQUEST

Summary

Font weight should be normal when filters are not applied & bold when filters are applied

Related Issue

Fixes N/A - this was a small request by Ashton

Screenshots

Filters not applied (all conditions selected):
Screenshot 2025-01-14 at 11 57 50
Filters are applied (only one selected):
Screenshot 2025-01-14 at 11 58 02

@angelathe
Copy link
Collaborator Author

@ashton-skylight Added screenshots, ready for design approval!

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.20%. Comparing base (7c75a98) to head (ce55d2c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3129      +/-   ##
==========================================
+ Coverage   87.03%   89.20%   +2.17%     
==========================================
  Files         220       83     -137     
  Lines       13674     4243    -9431     
  Branches      727      727              
==========================================
- Hits        11901     3785    -8116     
+ Misses       1753      438    -1315     
  Partials       20       20              
Flag Coverage Δ
ecr-viewer 90.98% <ø> (ø)
fhir-converter ?
ingestion ?
message-parser ?
message-refiner ?
orchestration 85.67% <ø> (ø)
record-linkage ?
trigger-code-reference ?
validation ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 137 files with indirect coverage changes

@ashton-skylight
Copy link
Collaborator

@angelathe You are a star!! Thank you looks great

Copy link
Collaborator

@mcmcgrath13 mcmcgrath13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚒️

@angelathe angelathe added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit 163cbd2 Jan 14, 2025
16 checks passed
@angelathe angelathe deleted the angela/filter-conditions-styling branch January 14, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants