Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move dispatching logic into fhir-data-service, dry out code #3130

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mcmcgrath13
Copy link
Collaborator

PULL REQUEST

Summary

Spin off/preparation PR from #3077. Refactor the fhir data service so the logic to do dispatching on source is in the service and not the route. Also simplify those db_getter functions so that they only do db getting and don't need to worry about mappings or wrangling params.

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 94.73684% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.17%. Comparing base (163cbd2) to head (7acd790).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...-viewer/src/app/api/fhir-data/fhir-data-service.ts 94.11% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3130      +/-   ##
==========================================
+ Coverage   87.03%   89.17%   +2.13%     
==========================================
  Files         220       83     -137     
  Lines       13674     4248    -9426     
  Branches      714      715       +1     
==========================================
- Hits        11901     3788    -8113     
+ Misses       1764      451    -1313     
  Partials        9        9              
Flag Coverage Δ
ecr-viewer 90.93% <94.73%> (-0.06%) ⬇️
fhir-converter ?
ingestion ?
message-parser ?
message-refiner ?
orchestration 85.67% <ø> (ø)
record-linkage ?
trigger-code-reference ?
validation ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ntainers/ecr-viewer/src/app/api/fhir-data/route.ts 100.00% <100.00%> (ø)
...-viewer/src/app/api/fhir-data/fhir-data-service.ts 95.65% <94.11%> (-2.60%) ⬇️

... and 137 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant