Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove ecr viewer metrics #3131

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mcmcgrath13
Copy link
Collaborator

PULL REQUEST

Summary

Spinoff/prep for #3077. Per discussion in standup, remove the metrics from the ecr viewer page. It isn't being used and also wasn't working correctly. This was the only place it was used, so also remove the helper and tests.

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.16%. Comparing base (163cbd2) to head (d3c3b61).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3131      +/-   ##
==========================================
+ Coverage   87.03%   89.16%   +2.13%     
==========================================
  Files         220       83     -137     
  Lines       13674     4227    -9447     
  Branches      714      721       +7     
==========================================
- Hits        11901     3769    -8132     
+ Misses       1764      438    -1326     
- Partials        9       20      +11     
Flag Coverage Δ
ecr-viewer 90.93% <ø> (-0.06%) ⬇️
fhir-converter ?
ingestion ?
message-parser ?
message-refiner ?
orchestration 85.67% <ø> (ø)
record-linkage ?
trigger-code-reference ?
validation ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...s/ecr-viewer/src/app/view-data/component-utils.tsx 100.00% <ø> (ø)
containers/ecr-viewer/src/app/view-data/page.tsx 90.69% <ø> (-0.80%) ⬇️

... and 141 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant