Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update release job to automatically generate release notes #3187

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

BobanL
Copy link
Collaborator

@BobanL BobanL commented Jan 23, 2025

PULL REQUEST

Summary

Related Issue

Fixes #3103

Acceptance Criteria

  • Release notes contain the title and description for each merged pull request included in the release
  • Pull requests that have been closed but not merged are not included in the release notes

Additional Information

Example of what gh release create 0.0.2 --generate-notes will create:
image

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.67%. Comparing base (bac3146) to head (55c6d0a).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3187      +/-   ##
==========================================
- Coverage   87.07%   85.67%   -1.40%     
==========================================
  Files         221       25     -196     
  Lines       13723     1424   -12299     
  Branches      739        0     -739     
==========================================
- Hits        11949     1220   -10729     
+ Misses       1753      204    -1549     
+ Partials       21        0      -21     
Flag Coverage Δ
ecr-viewer ?
fhir-converter ?
ingestion ?
message-parser ?
message-refiner ?
orchestration 85.67% <ø> (ø)
record-linkage ?
trigger-code-reference ?
validation ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 196 files with indirect coverage changes

Copy link
Collaborator

@mcmcgrath13 mcmcgrath13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ wow that's a lot simpler

@BobanL BobanL added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit 6dbf5cf Jan 23, 2025
10 checks passed
@BobanL BobanL deleted the boban/3103-release-notes branch January 23, 2025 21:41
robertmitchellv pushed a commit that referenced this pull request Jan 23, 2025
# PULL REQUEST

## Summary

- Update release action to auto generate release notes
- [Tag will get created if it does not
exist](https://cli.github.com/manual/gh_release_create#:~:text=If%20a%20matching%20git%20tag%20does%20not%20yet%20exist%2C%20one%20will%20automatically%20get%20created%20from%20the%20latest%20state%20of%20the%20default%20branch.)
- [Title will automatically be created based on the
tag](https://cli.github.com/manual/gh_release_create#:~:text=When%20using%20automatically%20generated%20release%20notes%2C%20a%20release%20title%20will%20also%20be%20automatically%20generated%20unless%20a%20title%20was%20explicitly%20passed.%20Additional%20release%20notes%20can%20be%20prepended%20to%20automatically%20generated%20notes%20by%20using%20the%20%2D%2Dnotes%20flag.)
 
## Related Issue

Fixes #3103

## Acceptance Criteria

- [x] Release notes contain the title and description for each merged
pull request included in the release
- [x] Pull requests that have been closed but not merged are not
included in the release notes

## Additional Information

Example of what `gh release create 0.0.2 --generate-notes` will create: 

![image](https://github.com/user-attachments/assets/d41ce1d8-bf95-4dab-a096-b8785969447c)

## Checklist

- [ ] If this code affects the other scrum team, have they been
notified? (In Slack, as reviewers, etc.)

[//]: # "PR title: Remember to name your PR descriptively!"
robertmitchellv pushed a commit that referenced this pull request Jan 24, 2025
# PULL REQUEST

## Summary

- Update release action to auto generate release notes
- [Tag will get created if it does not
exist](https://cli.github.com/manual/gh_release_create#:~:text=If%20a%20matching%20git%20tag%20does%20not%20yet%20exist%2C%20one%20will%20automatically%20get%20created%20from%20the%20latest%20state%20of%20the%20default%20branch.)
- [Title will automatically be created based on the
tag](https://cli.github.com/manual/gh_release_create#:~:text=When%20using%20automatically%20generated%20release%20notes%2C%20a%20release%20title%20will%20also%20be%20automatically%20generated%20unless%20a%20title%20was%20explicitly%20passed.%20Additional%20release%20notes%20can%20be%20prepended%20to%20automatically%20generated%20notes%20by%20using%20the%20%2D%2Dnotes%20flag.)
 
## Related Issue

Fixes #3103

## Acceptance Criteria

- [x] Release notes contain the title and description for each merged
pull request included in the release
- [x] Pull requests that have been closed but not merged are not
included in the release notes

## Additional Information

Example of what `gh release create 0.0.2 --generate-notes` will create: 

![image](https://github.com/user-attachments/assets/d41ce1d8-bf95-4dab-a096-b8785969447c)

## Checklist

- [ ] If this code affects the other scrum team, have they been
notified? (In Slack, as reviewers, etc.)

[//]: # "PR title: Remember to name your PR descriptively!"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve accuracy and detail of release notes
2 participants