Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor setting of default values #366

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Refactor setting of default values #366

merged 2 commits into from
Jan 16, 2025

Conversation

ventureoo
Copy link
Member

It allows to get rid of duplicating the variable name, which helps to avoid typical typo errors and looks prettier.

@ventureoo ventureoo marked this pull request as draft December 26, 2024 17:11
@ptr1337
Copy link
Member

ptr1337 commented Dec 26, 2024

Before pushing this the kernel manager likely needs adjustments.

@vnepogodin
Copy link
Member

Before pushing this the kernel manager likely needs adjustments.

we usually adjust kernel manager options after getting pushed into the linux-cachyos repo

Copy link
Member

@sirlucjan sirlucjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and everything works OK.

Signed-off-by: Vasiliy Stelmachenok <[email protected]>
@sirlucjan
Copy link
Member

Just small nit:

I saw that you rebased PR on top of tree, so you've also update propeller settings.

@ptr1337 ptr1337 merged commit 31da92e into master Jan 16, 2025
2 checks passed
@ptr1337 ptr1337 deleted the vladdy-pain branch January 16, 2025 20:21
vnepogodin added a commit to CachyOS/kernel-manager that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants