Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-6265] supplementary metadata #825

Merged

Conversation

aaxelb
Copy link
Contributor

@aaxelb aaxelb commented Sep 23, 2024

allow "supplementary" metadata records

  • declared by adding a is_supplementary query param (regardless of value) to a POST to /trove/ingest
  • added to all pre-existing index-cards from the same user with the same focus_iri (if any)
  • will not get an index-card of its own
  • will not affect the last-updated timestamp (e.g. in OAI-PMH) of the index-cards it supplements (<== this is the main point -- allows indexing monthly-computed metrics and system-specific administrative metadata without triggering full re-harvests every month)

@aaxelb aaxelb changed the title [wip] supplementary metadata [wip][ENG-6265] supplementary metadata Sep 23, 2024
@aaxelb aaxelb force-pushed the quest/supplementary-metadata branch from bd8f770 to 27d5900 Compare September 23, 2024 21:14
@aaxelb aaxelb force-pushed the quest/supplementary-metadata branch from 27d5900 to 1026817 Compare September 23, 2024 21:20
@coveralls
Copy link

coveralls commented Sep 23, 2024

Coverage Status

coverage: 90.262% (+0.4%) from 89.878%
when pulling 1026817 on aaxelb:quest/supplementary-metadata
into b15ff25 on CenterForOpenScience:develop.

@aaxelb aaxelb changed the title [wip][ENG-6265] supplementary metadata [ENG-6265] supplementary metadata Sep 30, 2024
@aaxelb aaxelb marked this pull request as ready for review September 30, 2024 19:44
@aaxelb aaxelb merged commit dea8c9b into CenterForOpenScience:develop Sep 30, 2024
3 checks passed
@aaxelb aaxelb deleted the quest/supplementary-metadata branch September 30, 2024 19:47
@brianjgeiger
Copy link

I'm not seeing a CR on this. Do we need to accelerate getting you help on SHARE? Getting folks doing CR might be a good way to start.

@aaxelb
Copy link
Contributor Author

aaxelb commented Oct 3, 2024

@brianjgeiger it was reviewed by @felliott in a call we had together, going thru each change and discussing what/why -- agree doing review together is a good way to share share knowledge, but will be sure to leave a comment (or harangue for actual github approval) when doing that in the future

@brianjgeiger
Copy link

@aaxelb Awesome, thank you. And thank you @felliott for the assistance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants