Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-6190] add to (and improve) osfmap-json shorthand #827

Merged
merged 3 commits into from
Oct 25, 2024
Merged

[ENG-6190] add to (and improve) osfmap-json shorthand #827

merged 3 commits into from
Oct 25, 2024

Conversation

aaxelb
Copy link
Contributor

@aaxelb aaxelb commented Oct 24, 2024 •
edited
Loading

  • add shorthands for new osfmap metadata properties:
    • qualifiedAttribution
    • agent
    • hadRole
    • usage
    • storageRegion
    • storageByteCount
    • hasOsfAddon
    • viewCount
    • viewSessionCount
    • downloadCount
    • downloadSessionCount
    • temporalCoverage
  • update osfmap_json deriver
    • consistently compact @id and @type iris
    • consistent value ordering
  • add test cases; add tests at all for trove.derive.osfmap_json

@coveralls
Copy link

Coverage Status

coverage: 90.61% (+0.2%) from 90.426%
when pulling e726600 on aaxelb:feature/6190-more-osfmap-shorthand
into 4fb6ed8 on CenterForOpenScience:develop.

@aaxelb aaxelb marked this pull request as ready for review October 24, 2024 20:45
@felliott
Copy link
Member

LGTM!

@aaxelb aaxelb merged commit ed13c34 into CenterForOpenScience:develop Oct 25, 2024
3 checks passed
@aaxelb aaxelb deleted the feature/6190-more-osfmap-shorthand branch October 25, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaxelb @coveralls @felliott