Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-5907] osfmap: suggest affiliation for preprints #837

Merged
merged 1 commit into from
Dec 5, 2024
Merged

[ENG-5907] osfmap: suggest affiliation for preprints #837

merged 1 commit into from
Dec 5, 2024

Conversation

aaxelb
Copy link
Contributor

@aaxelb aaxelb commented Dec 5, 2024

when feature flag PREPRINT_AFFILIATIONS is up, suggest affiliation instead of creator.affiliation for searching preprints

@aaxelb
[ENG-5907] suggest affiliation for preprints
7287509 
(when feature flag PREPRINT_AFFILIATIONS is up)
@aaxelb aaxelb marked this pull request as ready for review December 5, 2024 18:28
@aaxelb aaxelb changed the title [ENG-5907] suggest affiliation for preprints [ENG-5907] osfmap: suggest affiliation for preprints Dec 5, 2024
@aaxelb aaxelb requested a review from mfraezz December 5, 2024 18:33
@coveralls
Copy link

Coverage Status

coverage: 91.179%. remained the same
when pulling 7287509 on aaxelb:preprints-affiliated
into c85fb0d on CenterForOpenScience:develop.

mfraezz
mfraezz approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@mfraezz mfraezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⭐

@aaxelb aaxelb merged commit 6c6d881 into CenterForOpenScience:develop Dec 5, 2024
3 checks passed
@aaxelb aaxelb deleted the preprints-affiliated branch December 6, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfraezz mfraezz mfraezz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaxelb @coveralls @mfraezz