Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-6797][ENG-6711] sparse fieldsets for csv/tsv columns #838

Merged
merged 4 commits into from
Jan 6, 2025
Merged

[ENG-6797][ENG-6711] sparse fieldsets for csv/tsv columns #838

merged 4 commits into from
Jan 6, 2025

Conversation

aaxelb
Copy link
Contributor

@aaxelb aaxelb commented Jan 3, 2025 •
edited
Loading

  • ENG-6797: custom csv/tsv columns
    • support fields[TYPE]=... query param for search views
    • in addition to jsonapi sparse fieldsets, recognize when TYPE is a shorthand osfmap type and use it for csv/tsv column rendering
  • ENG-6711: when sorting by integer values, treat missing values as 0
  • fix: streaming json download

@coveralls
Copy link

coveralls commented Jan 3, 2025 •
edited
Loading

Coverage Status

coverage: 91.735% (-0.1%) from 91.833%
when pulling cc0e4c5 on aaxelb:fix/csv-columns
into 4dd2c09 on CenterForOpenScience:develop.

@aaxelb aaxelb changed the title sparse fieldsets for csv/tsv columns [ENG-6797] sparse fieldsets for csv/tsv columns Jan 6, 2025
@aaxelb aaxelb changed the title [ENG-6797] sparse fieldsets for csv/tsv columns [ENG-6797][ENG-6711] sparse fieldsets for csv/tsv columns Jan 6, 2025
@aaxelb aaxelb marked this pull request as ready for review January 6, 2025 15:17
@aaxelb aaxelb merged commit 1c7b570 into CenterForOpenScience:develop Jan 6, 2025
2 of 3 checks passed
@aaxelb aaxelb deleted the fix/csv-columns branch January 6, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfraezz mfraezz mfraezz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaxelb @coveralls @mfraezz