[ENG-6447] Update preprint model for versioning #2419
Conversation
| // Insert a `versions` relationship to the model | ||
| result.data.relationships!.versions = { | ||
| links: { | ||
| related: resourceHash.links!.preprint_versions!, | ||
| }, | ||
| }; |
There was a problem hiding this comment.
Why is this necessary?
There was a problem hiding this comment.
According to the API Contract, the API won't be serializing the Preprint.versions relationship, since it is recursive.
| preprintVersion: 1, | ||
| isLatestVersion: true, |
There was a problem hiding this comment.
If this is the latest version, shouldn't it be version 3 based on the withVersions afterCreate?
There was a problem hiding this comment.
withVersions is a factory trait, so only preprints created with that trait (server.create('preprint', 'withVersions')) will have 3 versions. Every other preprint will just have only 1 version.
| @@ -35,6 +36,8 @@ export function createPreprint(this: HandlerContext, schema: Schema) { | |||
| subjects: [], | |||
| tags: [] as string[] , | |||
| currentUserPermission: [Permission.Admin, Permission.Read, Permission.Write], | |||
| versionNumber: 1, | |||
There was a problem hiding this comment.
And I would presume this needs to be 3 as well?
There was a problem hiding this comment.
This is in the createPreprint view, so the versionNumber property for a freshly created preprint should just be 1 in this case. I will have a separate view for createPreprintVersion that will increment the versionNumber property
futa-ikeda
merged commit 500e4bd
into
CenterForOpenScience:feature/preprints-doi-versioning
Purpose
Summary of Changes
preprintVersionandisLatestVersionattrs to Preprintversionsrelationship to Preprintpreprint_versionURL that can be used to get versions, hence the chicanery with the preprint-serializerScreenshot(s)
Side Effects
QA Notes