Feature/institutional access #2471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er-osf-web into institutional-access-user-message-modal * 'develop' of https://github.com/CenterForOpenScience/ember-osf-web: Update CHANGELOG, bump version [ENG-5024] Feature/dashboard b and i (#2429) # Conflicts: # app/institutions/dashboard/-components/institutional-users-list/component.ts
…message-modal [ENG-6665] Add user messaging modal to user's tab on institutional dashboard
…terForOpenScience/ember-osf-web into institutional-access-project-request-modal * 'feature/institutional-access' of https://github.com/CenterForOpenScience/ember-osf-web: use proper Ember input tags, remove extra close modal command make message types an enum update language and fix modal closing bug. update to fit Product language and styling add checkboxes for reply-to and ccing Add type annotations for belongs to update text area for Ember type area update sendMessage to task fix label for message box add aira-label. fix en-us typo Add user messaging modal to user's tab on institutional dashboard
…er-osf-web into institutional-access-project-request-modal * 'develop' of https://github.com/CenterForOpenScience/ember-osf-web: Bump version no. Add CHANGELOG. Feature/share download integration (#2457)
…er-osf-web into institutional-access-project-request-modal * 'develop' of https://github.com/CenterForOpenScience/ember-osf-web: Update CHANGELOG, bump version Fix funder column propertyPathKey Bump version no. Add CHANGELOG. Feature/share download integration (#2457)
…github.com/CenterForOpenScience/ember-osf-web into institutional-access-project-request-modal * 'institutional-access-project-request-modal' of https://github.com/CenterForOpenScience/ember-osf-web: integrations fixes and refactors Update CHANGELOG, bump version Fix funder column propertyPathKey Bump version no. Add CHANGELOG. Feature/share download integration (#2457) Bump version no. Add CHANGELOG. Feature/share download integration (#2457) add Project request modal with user messaging tab to the institutional dashboard # Conflicts: # app/institutions/dashboard/-components/object-list/component.ts # app/institutions/dashboard/-components/object-list/template.hbs # app/models/node-request.ts
…ct-request-modal [ENG-6669] Institutional Access project Request Modal
[IAC][Bug] Fix User Messaging Tab Adapter Bug
Feature/institutional access
Pull Request Test Coverage Report for Build 12836329841Details
💛 - Coveralls |
Johnetordoff
commented
Jan 16, 2025
| @@ -10,6 +11,7 @@ import InstitutionModel from 'ember-osf-web/models/institution'; | |||
| import InstitutionDepartmentsModel from 'ember-osf-web/models/institution-department'; | |||
| import Analytics from 'ember-osf-web/services/analytics'; | |||
| import { RelationshipWithLinks } from 'osf-api'; | |||
| import {MessageTypeChoices} from 'ember-osf-web/models/user-message'; | |||
Johnetordoff
commented
Jan 16, 2025
app/institutions/dashboard/-components/object-list/component-test.ts
Outdated
Show resolved
Hide resolved
Johnetordoff
commented
Jan 16, 2025
app/institutions/dashboard/-components/object-list/component.ts
Outdated
Show resolved
Hide resolved
Johnetordoff
commented
Jan 16, 2025
app/institutions/dashboard/-components/object-list/component.ts
Outdated
Show resolved
Hide resolved
revert/restore old code
fix typo and fix issue preventing pop-up modal from popping up
fix issue with not including error response codes in payload
futa-ikeda
previously approved these changes
Jan 17, 2025
| import OsfAdapter from './osf-adapter'; | ||
|
|
||
| export default class NodeRequestAdapter extends OsfAdapter { | ||
| @service session; |
There was a problem hiding this comment.
Nit: doesn't look like you need this line and any imports for it
There was a problem hiding this comment.
@Johnetordoff This looks like it's still there, but you marked it as resolved without additional comment. What's going on with this?
There was a problem hiding this comment.
I must have missed it sorry, let me remove it.
|
And it looks like the percy changes are just RNG text/image jitter, so I can approve it whenever we are ready to merge this to develop |
update translation to remove html tag
brianjgeiger
requested changes
Jan 17, 2025
app/institutions/dashboard/-components/object-list/contributors-field/component.ts
Outdated
Show resolved
Hide resolved
brianjgeiger
approved these changes
Jan 21, 2025
|
@futa-ikeda This is ready to go to develop. Could you approve Percy? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Summary of Changes
Screenshot(s)
Side Effects
QA Notes