Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update translation to remove html tag #2480

Merged
merged 1 commit into from
Jan 17, 2025
Merged

update translation to remove html tag #2480

merged 1 commit into from
Jan 17, 2025

Conversation

Johnetordoff
Copy link
Collaborator

  • Ticket: []
  • Feature flag: n/a

Purpose

Summary of Changes

Screenshot(s)

Side Effects

QA Notes

futa-ikeda
futa-ikeda approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@futa-ikeda futa-ikeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I suppose you could remove the htmlSafe option when that translation string is invoked, but that’s more of a nit

@Johnetordoff Johnetordoff merged commit 56c156b into CenterForOpenScience:feature/institutional-access Jan 17, 2025
9 checks passed
@futa-ikeda futa-ikeda added this to the 25.02.0 milestone Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@futa-ikeda futa-ikeda futa-ikeda approved these changes

@brianjgeiger brianjgeiger brianjgeiger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
25.02.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Johnetordoff @brianjgeiger @futa-ikeda