Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HAI-3355 Add haittojenhallintasuunnitelma from hankealue to the PDF #925

Open
wants to merge 1 commit into
base: HAI-3354/hhs-to-pdf
Choose a base branch
from

Conversation

corvidian
Copy link
Contributor

Description

Add haittojenhallintasuunnitelma from hankealue to the PDF

Jira Issue: https://helsinkisolutionoffice.atlassian.net/browse/HAI-3355

Type of change

  • Bug fix
  • New feature
  • Other

Instructions for testing

Send a kaivuilmoitus to Allu and check the attachment in Allu. There's also a temporary test that creates example PDFs.

Checklist:

  • I have written new tests (if applicable)
  • I have ran the tests myself (if applicable)
  • I have made necessary changes to the documentation, link to confluence
    or other location:

@corvidian corvidian force-pushed the HAI-3355/hankealue-hhs-to-pdf branch from cecf827 to a52ff5e Compare January 15, 2025 13:29
@@ -77,105 +81,164 @@ class HaittojenhallintasuunnitelmaPdfEncoder(private val mapGenerator: MapGenera
val worstIndexes = kaivuilmoitusalue.worstCasesInTormaystarkastelut()

document.section(hankealue.nimi) {
row("Toimet työalueiden haittojen hallintaan, ${hankealue.nimi}", toimetTitle())
row("", nuisanceScore(worstIndexes?.liikennehaittaindeksi?.indeksi))
hankealueRow(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could all these sections be in separate functions in order to shorten the formatPdf function?

Copy link
Contributor

@umeetiusbaar umeetiusbaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with UI and Allu and the pdf looks as it should. Really nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants