add extracted device id to kafka raw data topic #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aapris
requested changes
Oct 17, 2023
tests/test_api2.py
Outdated
| @@ -94,7 +94,7 @@ def test_digita_endppoint_authenticated_access(): | |||
| # Replace Time with ~current time | |||
| ts = (datetime.now(timezone.utc) - timedelta(seconds=1)).strftime("%Y-%m-%dT%H:%M:%S.%f%z") | |||
| payload["DevEUI_uplink"]["Time"] = ts | |||
| resp = httpx.post(url, headers=headers, params=params, data=payload) | |||
| resp = httpx.post(url, headers=headers, params=params, data=json.dumps(payload)) | |||
There was a problem hiding this comment.
It is better to use json=payload when httpx.post()ing, e.g.
resp = httpx.post(url, headers=headers, params=params, json=payload)
There was a problem hiding this comment.
On my machine dev set up, resp = httpx.post(url, headers=headers, params=params, json=payload) makes the parser error out at json.loads(data["request"]["body"].decode()) because the body comes as url encoded. b'DevEUI_uplink=%7B%27Time%27%3A+%272023-10-17T08%3A32%3A1 ..
data=json.dumps(payload) fixes this issue. Do parser work with just 'payload' for you ? @aapris
sheenacodes
force-pushed
the
feature/add-device-id-to-kafka-raw-data
branch
from
e2e9c12 to
5693562
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added already extracted device id to kafka raw data. this avoids extracting again from request params/body on parser.app