contributing: update to reference single line braces #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried looking into clang-tidy as an option to fix this - but didn't find anything straight forward bar the clang-format option called InsertBraces, but it doesn't arrive till clang-format version 15... |
jeffreybshaw
approved these changes
Dec 16, 2022
There was a problem hiding this comment.
This content is duplicated on https://github.com/CloudNativeDataPlane/cloudnativedataplane.github.io/blob/main/dev.md, do you want to update it there, too? We can create a reminder issue in that repo (or this one) so we don't forget.
I will push an update there too :) |
KeithWiles
approved these changes
Dec 17, 2022
maryamtahhan
force-pushed
the
hotfix_contrib_doc
branch
from
43a808c to
e7bcf8a
Compare
maryamtahhan
force-pushed
the
hotfix_contrib_doc
branch
from
e7bcf8a to
8fe2674
Compare
Signed-off-by: Maryam Tahhan <[email protected]>
Signed-off-by: Maryam Tahhan <[email protected]>
KeithWiles
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Maryam Tahhan [email protected]