Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rust workflow #290

Merged
merged 3 commits into from
Apr 29, 2023
Merged

Create rust workflow #290

merged 3 commits into from
Apr 29, 2023

Conversation

maryamtahhan
Copy link
Contributor

Add a build to run the rust pipeline

@KeithWiles
Copy link
Contributor

Missing a DCO :-)

@maryamtahhan
Copy link
Contributor Author

Missing a DCO :-)

Yep I will fixup when I get the pipeline running :) sorry about that.

the pipeline is failing unexpectedly with:

The following warnings were emitted during compilation:

warning: src/c_src/bindings.c:5:10: fatal error: pktdev.h: No such file or directory
warning:     5 | #include <pktdev.h>          // for pktdev_rx_burst, pktdev_tx_burst
warning:       |          ^~~~~~~~~~
warning: compilation terminated.

error: failed to run custom build command for `cndp-cne-sys v0.2.0 (https://github.com/CloudNativeDataPlane/cndp?branch=main#f86286d5)`

Caused by:
  process didn't exit successfully: `/home/runner/work/cndp/cndp/lang/rs/target/debug/build/cndp-cne-sys-978e8b1bf782987d/build-script-build` (exit status: 1)
  --- stdout

@KeithWiles
Copy link
Contributor

I ran the 'cd lang/rs; cargo build' and got the following error, most likely I do not have it installed as expected.

The Meson build system
  Version: 1.0.0
  Source dir: /home/rkwiles/.cargo/git/checkouts/cndp-401ada570b51f4b3/e7839cd/lang/rs/bindings/cne-sys/src/c_src
  Build dir: /work/projects/intel/networking.dataplane/cndp/lang/rs/target/debug/build/cndp-cne-sys-a6abb6c5a95a9b21/out
  Build type: native build
  Project name: CNDP CNE bindings for Rust
  Project version: 1.0.0
  C compiler for the host machine: ccache cc (gcc 12.2.0 "cc (Ubuntu 12.2.0-3ubuntu1) 12.2.0")
  C linker for the host machine: cc ld.bfd 2.39
  Host machine cpu family: x86_64
  Host machine cpu: x86_64
  Found pkg-config: /bin/pkg-config (0.29.2)
  Run-time dependency libcndp found: NO (tried pkgconfig)

  meson.build:24:0: ERROR: Include dir /usr/local/include/cndp does not exist.

  A full log can be found at /work/projects/intel/networking.dataplane/cndp/lang/rs/target/debug/build/cndp-cne-sys-a6abb6c5a95a9b21/out/meson-logs/meson-log.txt
  WARNING: Running the setup command as `meson [options]` instead of `meson setup [options]` is ambiguous and deprecated.

  --- stderr
  thread 'main' panicked at 'assertion failed: status.success()', /home/rkwiles/.cargo/registry/src/index.crates.io-6f17d22bba15001f/meson-1.0.0/src/lib.rs:72:5
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Must be missing a step.

@maryamtahhan
Copy link
Contributor Author

Must be missing a step.
TY, Yeah I think so... just trying to update the pipeline now based on the README :)

@maryamtahhan maryamtahhan force-pushed the maryamtahhan-patch-1 branch from 6815d66 to b5529db Compare April 25, 2023 15:46
@maryamtahhan
Copy link
Contributor Author

Lol, so it builds now but the tests fail :)

I'll try and debug a little more tomorrow.

@KeithWiles
Copy link
Contributor

:-( have a great night.

@maryamtahhan
Copy link
Contributor Author

I think there's a bit more to do with the test debug for now - so I'm putting it on the back burner with an issue to look at later... that way we can still get this workflow for at least building the rust code running regularly.

@KeithWiles
Copy link
Contributor

Hi Maryam, are you ready to have this one approved and merged?

@maryamtahhan
Copy link
Contributor Author

yes - this is ready.

The unit tests need to be fixed separately and have issues open against them - so they are out of scope for this PR

@KeithWiles KeithWiles merged commit 59073dd into main Apr 29, 2023
@KeithWiles KeithWiles deleted the maryamtahhan-patch-1 branch April 29, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants