Adds check for whether directory is actually a bundle before moving children out #85
Conversation
| def isBundle?(entry) | ||
| isBundle = File.extname(entry) == '.framework' | ||
| isBundle ||= File.extname(entry) == '.app' | ||
| isBundle ||= File.extname(entry) == '.framework' |
There was a problem hiding this comment.
what about resource.bundles?
There was a problem hiding this comment.
Correct, I accidentally duplicated the line. Will correct and commit change. As for the resource.bundles, should cocoapods check just for the .bundles that way it doesn't miss out on non-resource ones?
There was a problem hiding this comment.
yep any .bundle should be caught by this
| # @return [Bool] Whether the entry is a bundle | ||
| # | ||
|
|
||
| def isBundle?(entry) |
There was a problem hiding this comment.
nit: rename to is_bundle? and remove the extra empty line above the function declaration
There was a problem hiding this comment.
I can rename the method and remove the line, but I don't know how to write unit tests in ruby.
As for the CHANGELOG entry, I also wasn't sure of the proper git flow for Cocoapods, so I made the PR into master. Should I then put the entry under Master > Bug Fixes?
|
I’m not sure I love this change — seems better to just specify flatten: false? |
|
is that configurable in the Podspec? I'm not too familiar with this, but if something like this is possible then yes I agree spec.source = {
:http => 'some_url',
:flatten => false
} |
|
Going to close as the |
Checks whether post-uncompressed directory is a bundle. If so, do not move the contents out. #84
I don't know if this is an exhaustive list of extensions for bundles that masquerade as directories, but I wanted to put up at least a first pass at a solution that worked for at least some of them.