-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Old Commons-ui section #1019
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Kipruto <[email protected]>
Signed-off-by: Kipruto <[email protected]>
Signed-off-by: Kipruto <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽 ... haven't run it locally yet but code looks good.
No test for QuickLinks
?
function Section({ className, fixed = true, ...props }) { | ||
const classes = useStyles(props); | ||
|
||
function Section({ fixed = true, sx, ...props }) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need custom Section
? Ideally the commons/ui/Section
component should be flexible/reusable enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kilemensi yes. We have to give each Section
a fixed width. Rather than do so at each place it is used, having a custom one is much better and cleaner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 ... I just glanced at the code @kelvinkipruto and could be wrong but isn't the code in this PR exactly like the one in commons-ui/core/Section
already? Of course, theme.widths
was renamed to theme.contentWidths
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Kipruto <[email protected]>
Signed-off-by: Kipruto <[email protected]>
Signed-off-by: Kipruto <[email protected]>
Description
This PR remove Legacy
common-ui
dependencyType of change
Screenshots
Checklist: