Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Old Commons-ui section #1019

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conversation

kelvinkipruto
Copy link
Contributor

@kelvinkipruto kelvinkipruto commented Dec 14, 2024

Description

This PR remove Legacy common-ui dependency

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Screenshots

image
image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@kelvinkipruto kelvinkipruto marked this pull request as ready for review January 9, 2025 15:09
Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽 ... haven't run it locally yet but code looks good.


No test for QuickLinks?

apps/climatemappedafrica/src/components/Footer/index.js Outdated Show resolved Hide resolved
function Section({ className, fixed = true, ...props }) {
const classes = useStyles(props);

function Section({ fixed = true, sx, ...props }) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need custom Section? Ideally the commons/ui/Section component should be flexible/reusable enough.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kilemensi yes. We have to give each Section a fixed width. Rather than do so at each place it is used, having a custom one is much better and cleaner.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 ... I just glanced at the code @kelvinkipruto and could be wrong but isn't the code in this PR exactly like the one in commons-ui/core/Section already? Of course, theme.widths was renamed to theme.contentWidths.

packages/commons-ui-core/src/Copyright/Copyright.js Outdated Show resolved Hide resolved
packages/commons-ui-core/src/Copyright/Copyright.test.js Outdated Show resolved Hide resolved
packages/commons-ui-core/src/Copyright/Copyright.js Outdated Show resolved Hide resolved
packages/commons-ui-core/src/QuickLinks/QuickLinks.js Outdated Show resolved Hide resolved
packages/commons-ui-core/src/QuickLinks/QuickLinks.js Outdated Show resolved Hide resolved
packages/commons-ui-core/src/QuickLinks/QuickLinks.js Outdated Show resolved Hide resolved
Copy link
Contributor

@m453h m453h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested locally and it looks good, there is one minor issue regarding the legend, it does slightly overlap the map, It would be better if we add a bit of space between it and the map (perhaps increase the map height and / hero component height to match the changes)

Screenshot 2025-01-10 at 10 57 19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants