Skip to content

Commit

Permalink
feat: upgrade to the [email protected] (#691)
Browse files Browse the repository at this point in the history
* removed unnecessary workflows for the node.js 14 and 16,
* updated the Node.js engine version to >= 18
  • Loading branch information
pantyporowicz-squiz committed Oct 24, 2024
1 parent 599bc83 commit 09401c7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 9 deletions.
9 changes: 1 addition & 8 deletions .github/workflows/release-on-push-to-mainline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [14.x, 16.x, 18.x, 20.x]
node-version: [18.x, 20.x, 22.x]
steps:
- name: Checkout
uses: actions/checkout@v4
Expand All @@ -20,14 +20,7 @@ jobs:
with:
node-version: ${{ matrix.node-version }}

# 14.x fails with "npm ERR! Cannot read property '@commitlint/config-conventional' of undefined"
# when running `npm ci` due to the new package-lock.json format. Run `npm i` instead
- name: Install (14.x)
if: matrix.node-version == '14.x'
run: npm i

- name: Install
if: matrix.node-version != '14.x'
run: npm ci

- name: Test
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"url": "https://github.com/CodeGenieApp/serverless-express.git"
},
"engines": {
"node": ">=12"
"node": ">=18"
},
"publishConfig": {
"access": "public"
Expand Down

0 comments on commit 09401c7

Please sign in to comment.