Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to the [email protected] (#691) #692

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

pnkp
Copy link
Contributor

@pnkp pnkp commented Oct 21, 2024

Issue: #691

Description of changes:

  • upgraded to the [email protected],
  • adjusted the ServerlessRequest to the [email protected] implementation,
  • ran: npm audit and npm audit fix,
  • upgrade ejs to 3.1.10,
  • added .idea folder to gitignore,
  • removed unnecessary workflows for the node.js 14 and 16,
  • updated the Node.js engine version to >= 18

Checklist

  • Tests have been added and are passing
  • Documentation has been updated

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

* upgraded to the [email protected],
* adjusted the ServerlessRequest to the [email protected] implementation,
* ran: npm audit and npm audit fix,
@brettstack
Copy link
Collaborator

Thanks for this! Is this backwards compatible? So you can use either express v4 or v5 with this change?

@pnkp
Copy link
Contributor Author

pnkp commented Oct 22, 2024

Thanks for this! Is this backwards compatible? So you can use either express v4 or v5 with this change?

I haven't checked, but I will

Edited:
It works for v4 and v5 express.

@pnkp
Copy link
Contributor Author

pnkp commented Oct 24, 2024

@brettstack FYI. In terms of backwards compability, the [email protected] is compatible with the Node.js >= 18.

* removed unnecessary workflows for the node.js 14 and 16,
* updated the Node.js engine version to >= 18
@brettstack brettstack merged commit d20e3f0 into CodeGenieApp:mainline Oct 24, 2024
4 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 24, 2024
# [4.16.0](v4.15.0...v4.16.0) (2024-10-24)

### Features

* add support for Express v5 ([#691](#691)) ([#692](#692)) ([d20e3f0](d20e3f0))
Copy link

🎉 This PR is included in version 4.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@pnkp
Copy link
Contributor Author

pnkp commented Oct 25, 2024

@brettstack when will you release in the npm?

@brettstack
Copy link
Collaborator

It's out! Version 4.16.0. I've also updated https://codegenie.codes/ to use this latest version.

@pnkp
Copy link
Contributor Author

pnkp commented Oct 25, 2024

I can't this version under the npm package: https://www.npmjs.com/package/@vendia/serverless-express?activeTab=versions
image

@brettstack
Copy link
Collaborator

This package is now published under https://www.npmjs.com/package/@codegenie/serverless-express/v/4.16.0

@pnkp
Copy link
Contributor Author

pnkp commented Oct 25, 2024

This package is now published under https://www.npmjs.com/package/@codegenie/serverless-express/v/4.16.0

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants