Skip to content
This repository has been archived by the owner on Jan 14, 2024. It is now read-only.

London10-StellaDelMar_RodriguezFernandez-JavaScript-Core-1-Coursework-Week4 #240

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Stelladelmar
Copy link

will do mandatory

from g to i. exercises
allExercises
@Stelladelmar Stelladelmar added the review requested I would like a mentor to review my PR label Apr 19, 2023
}

//***************************************************

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually we don't use ! in our arguments. Also the error code still needs to be returned (in the comments below).

return students.includes(any);
}
console.log(groupIsOnlyStudents);

Copy link

@ButcherDing ButcherDing Apr 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'any' isn't defined anywhere, and maybe rethink what is going to go inside .every().
.every() takes an array and gives us back 'true' if every element passes a certain test - this test can be a function - It looks like this is what you were trying to do.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏 I see

let pairsByIndex = pairsByIndexRaw.filter( item => item.length === 2);


// Complete this statement

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

MANDsomeATORY
@migmow migmow added the reviewed A mentor has reviewed this code label May 5, 2023
@Stelladelmar Stelladelmar changed the title exercices(nomandatory) London10-StellaDelMar_RodriguezFernandez-JavaScript-Core-1-Coursework-Week4 May 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
review requested I would like a mentor to review my PR reviewed A mentor has reviewed this code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants