Fixed action scheduler time issue with old method

[girishpanchal30]

Summary

In this PR, I've fixed the Action Scheduler issue by addressing the older method. I've updated the condition to prioritize checking for the older method before evaluating other conditions.

Will affect visual aspect of the product

Yes

Check before Pull Request is ready:

• I have written a test and included it in this PR
• I have run all tests and they pass
• The code passes when running the PHP CodeSniffer
• Code meets WordPress Coding Standards for PHP, HTML, CSS and JS
• Security and Sanitization requirements have been followed
• I have assigned a reviewer or two to review this PR (if you're not sure who to assign, we can do this step for you)

Closes https://github.com/Codeinwp/feedzy-rss-feeds-pro/issues/815

[vytisbulkevicius]

Hey @girishpanchal30,

Seems like some checks failed and build was not created here

[pirate-bot]

Plugin build for 770b335 is ready 🛎️!

• Download build

[vytisbulkevicius]

Looks like the build is here now after re-triggering the job but some checks still failed

[selul]

@girishpanchal30 can you explain a bit how this fixes the issue? If it was a function missing issue it would have thrown a fatal error not a wrong timestamp?

[girishpanchal30]

@selul Sure!

as_has_scheduled_action function returns true or false if a scheduled action is found, while the as_next_scheduled_action function returns a timestamp or false.
So, I first check the next scheduled action using as_next_scheduled_action function and then check if the action is pending or in progress using as_has_scheduled_action.

[selul]

@girishpanchal30 thanks for the explanation, makes sense now. When the as_has_scheduled_action returns true what's the timestamp that the user will use? Maybe in this case we can show in progress or something instead of the timestamp.

Great findings btw.

[girishpanchal30]

@selul

Maybe in this case we can show in progress or something instead of the timestamp.

I’ve added the in progress status text.

@vytisbulkevicius Now all checklist are passed.

[selul]

lgtm

[HardeepAsrani]

LGTM, thanks for the explanation in the thread as I was also confused why having the older method is better than the newer one.