Dockerize app

[kareemmahlees]

What type of Pull Request is this?

Delete all options except for the one that applies

• Feature

What is the current behavior?

Issue Number: #50

What is the new behavior?

• An image is built for the app
• The image was provided to the docker-compose
• the app is dependent on the db

Other information

I would like to hear your feedback if everything is okay before moving on to add this section to the CONTRIBUTING file

[w3cj]

Let's focus on a production build version of the svelte app and put it in a separate docker-compose file docker-compose.prod.yml. This file should only have the app service and not the db service.

I've added a node adapter for the svelte build. I'll add some comments on your PR on how you can target the production build in the Dockerfile

I'll note that the setup for using docker in development will be a bit different, but lets do that in a separate PR after we have the production one setup.

[w3cj]

All of the environment variables will need to be exposed. See .env.example for a list of them.

[kareemmahlees]

All of the environment variables will need to be exposed. See .env.example for a list of them.

I am not really sure I understand what you mean by exposed ?!

[w3cj]

I'm not sure how .dockerignore is used exactly, but for a development container (which we'll setup later), these configuration files will be needed. They will likely be mapped to a volume that mirrors this directory.

[kareemmahlees]

I'm not sure how .dockerignore is used exactly, but for a development container (which we'll setup later), these configuration files will be needed. They will likely be mapped to a volume that mirrors this directory.

Do you mean you want to create a dev container where the users can open their vscode inside the container and work from there?

[omar2205]

Two containers (docker-compose) files, dev and prod versions.

[kareemmahlees]

Two containers (docker-compose) files, dev and prod versions.

I did that in the latest commit, but I kept the configuration files ignored in .dockerignore and every thing seems to run ok!

[omar2205]

adds a second stage to run the production app

[w3cj]

There are several changes I need you to make, so lets just focus on the production Dockerfile and docker-compose.prod.yml for now.

Remove docker-compose.dev.yml and .dockerignore, we will add these in a future PR where we can discuss the development container specifically.

Dockerfile:

1. Should run the command npm run build
2. Should copy files from the generated folder called build instead of the whole app
3. Should expose port 3000
4. Should run the command node build

docker-compose.prod.yml:

1. Remove depends_on: - db - the production container will connect to a remote DB
2. Every environment variable listed in the .env.example file should be listed under environment

Remove current changes to the docker-compose.yml file

[w3cj]

See comment above.

[kareemmahlees]

@w3cj sorry for being late, was busy lately.
i did all the changes mentioned here:

There are several changes I need you to make, so lets just focus on the production Dockerfile and docker-compose.prod.yml for now.

but regarding this part:

Every environment variable listed in the .env.example file should be listed under environment

couldn't we just do this:

 env_file:
    - .env

[w3cj]

Thanks for this. Looks good, but the original docker-compose.yml file got deleted. Be sure to leave the original as well as the new one you created.

[w3cj]

I think we want to avoid doing this, because the production container likely won't have a .env file. The variables will already be loaded in the system or specified when launching the container.

[kareemmahlees]

@w3cj Done, could you check?

[w3cj]

Is there a reason to split the build and run into separate containers?

[omar2205]

To limit the image size?

[w3cj]

Ok seems fine then, but does there need to be an EXPOSE and CMD for the first stage? Isn't it needed for only the second container?

[omar2205]

Yeah, @kareemmahlees just remove the EXPOSE and CMD node build from the build stage.