Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Track stuck error message and detect when a track is stuck so that it can be skipped. #5630

Closed
wants to merge 1 commit into from

Conversation

Drapersniper
Copy link
Contributor

@Drapersniper Drapersniper commented Mar 21, 2022

Description of the changes

Updated Track stuck message - Changed from
Playback of the song has stopped due to an unexpected error.\n{error}
to
Playback of the song was unable to continue.\n{error}

Have the changes in this PR been tested?

Yes

Test cases

  • Start playback and pause for 30s.
  • Start playback then Disconnect player and wait 30s
  • Start playback and run the stop command and wait for 30s
  • Leave it on autoplay for 24/7 and monitor the bot messages for Track stuck messages

Needs the following 2 prs to be merged so this one can be installed:
#5631
#5629

Alternatively use #5640

@Drapersniper
Copy link
Contributor Author

What to test

  • Ensure the bot doesn't get stuck in a Track Stuck loop

What to expect

1 - When playing something if RLL stops getting track position updates for more than 15s a manual track stuck update should be fired
2 - The fired track stuck should cause the track to be skipped and a new one played on this place (if autoplay is enable of there are tracks in the queue)
3 - You shouldn't get stuck on a track stuck loop (every track you enqueue is marked as stuck after 15s of it being playing continuously)

@Drapersniper Drapersniper force-pushed the rll_118 branch 2 times, most recently from 9c94a47 to e4491db Compare March 31, 2022 10:41
@github-actions github-actions bot added the Category: Cogs - Audio This is related to the Audio cog. label Apr 2, 2022
@Drapersniper Drapersniper marked this pull request as ready for review April 2, 2022 14:42
@Drapersniper Drapersniper changed the title Update audio to use https://github.com/Cog-Creators/Red-Lavalink/pull/118 Update Track stuck error message to be less ambiguous about issue. Apr 2, 2022
@Drapersniper Drapersniper changed the title Update Track stuck error message to be less ambiguous about issue. Update Track stuck error message and detect when a track is stuck so that it can be skipped. Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Cogs - Audio This is related to the Audio cog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant