[0.9.x] Avoid infinite iteration over queue on reconnect #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackenmen
force-pushed
the
avoid_infinite_iteration_on_reconnect
branch
from
295020d to
d117c36
Compare
aikaterna
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.send()may append the element it received if the WebSocket is closed which has caused infinite expansion ofNode._queueover which we iterate inNode.connect().This fix was already incorporated into
developin #117 and this is a backport of that one specific change into 0.9.x branch.This PR aims to solve the same problem that #129 does but it does it in a way that is less invasive to the existing code base which is preferred for a maintenance release to 0.9.x rather than the main development line. This should make it less likely to cause other issues that would require us to make another release.